Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error on Django admin if approving a domain with a duplicate name #1263

Closed
2 tasks
abroddrick opened this issue Nov 6, 2023 · 6 comments · Fixed by #2888
Closed
2 tasks

Show error on Django admin if approving a domain with a duplicate name #1263

abroddrick opened this issue Nov 6, 2023 · 6 comments · Fixed by #2888
Assignees
Labels
dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow Feature: ❔ Request a Domain

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Nov 6, 2023

Issue description

A domain request can not be approved by an analyst if a domain was already approved with that identical name. In this case, when an analyst goes to approve the duplicate domain request on django admin, they get an ugly 500 error with no information as to what happened.

Acceptance criteria

  • if an analyst tries to approve a domain request with a domain name that is already in use (and not deleted) show an error message not a 500 error. The domain request should not move to approved in this case.
  • the content of the error message should be "The domain name for this request is already in use. The name will need to be updated before this request can be approved."

Additional context

No response

Links to other issues

No response

@abroddrick abroddrick added the dev issue is for the dev team label Nov 6, 2023
@abroddrick
Copy link
Contributor Author

@Katherine-Osos I am thinking this would just be an error that explains "The domain name selected is already in use, please select an alternative domain name on this application before approving." Or something like that. Do you want a separate content ticket, or do you think since it's a one liner the designer PR reviewing can just comment on the PR with what language they prefer?

@PaulKuykendall PaulKuykendall moved this from 👶 New to 🍦 Backlog in .gov Product Board Nov 9, 2023
@vickyszuchin vickyszuchin moved this from 🍦 Backlog to 🔖 Planned in .gov Product Board Feb 12, 2024
@vickyszuchin vickyszuchin moved this from 🔖 Planned to 🍦 Backlog in .gov Product Board Feb 13, 2024
@abroddrick
Copy link
Contributor Author

@Katherine-Osos retagging for the question above

@Katherine-Osos
Copy link
Contributor

It seems worthwhile to alert the analyst long before they approve. Like some sort of flag that appears on the request when more than one request has the same name. Do we have a ticket for something like that?

As for error messaging, let's try:

The domain name for this request is already in use. The name will need to be updated before this request can be approved.

@katypies katypies added bug Something that isn't working as intended Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow labels Aug 2, 2024
@PaulKuykendall
Copy link

@abroddrick - is this overcome by events? Or do we still need to consider?

@abroddrick
Copy link
Contributor Author

Missed this tag. @Katherine-Osos no we do not have a ticket for adding some sort of flag on the domain request if the name is a duplicate of something else that is approved. We would need a new ticket for that. Copying the content for the error message Katherine mentions above into the AC

@abroddrick
Copy link
Contributor Author

abroddrick commented Sep 16, 2024

@katypies , why does this have a bug tag? This is a new feature beyond things initially planned, not a feature that is not operating as designed. I would like to remove the "bug" label as it is a bit misleading.

@PaulKuykendall PaulKuykendall removed the bug Something that isn't working as intended label Sep 30, 2024
@PaulKuykendall PaulKuykendall moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Sep 30, 2024
@PaulKuykendall PaulKuykendall moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Oct 2, 2024
@vickyszuchin vickyszuchin moved this from 🔖 Planned to 👀 In review in .gov Product Board Oct 3, 2024
rachidatecs added a commit that referenced this issue Oct 8, 2024
#1263 Request error: Already approved domain - [RJM]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow Feature: ❔ Request a Domain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants