-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error on Django admin if approving a domain with a duplicate name #1263
Comments
@Katherine-Osos I am thinking this would just be an error that explains "The domain name selected is already in use, please select an alternative domain name on this application before approving." Or something like that. Do you want a separate content ticket, or do you think since it's a one liner the designer PR reviewing can just comment on the PR with what language they prefer? |
@Katherine-Osos retagging for the question above |
It seems worthwhile to alert the analyst long before they approve. Like some sort of flag that appears on the request when more than one request has the same name. Do we have a ticket for something like that? As for error messaging, let's try:
|
@abroddrick - is this overcome by events? Or do we still need to consider? |
Missed this tag. @Katherine-Osos no we do not have a ticket for adding some sort of flag on the domain request if the name is a duplicate of something else that is approved. We would need a new ticket for that. Copying the content for the error message Katherine mentions above into the AC |
@katypies , why does this have a bug tag? This is a new feature beyond things initially planned, not a feature that is not operating as designed. I would like to remove the "bug" label as it is a bit misleading. |
#1263 Request error: Already approved domain - [RJM]
Issue description
A domain request can not be approved by an analyst if a domain was already approved with that identical name. In this case, when an analyst goes to approve the duplicate domain request on django admin, they get an ugly 500 error with no information as to what happened.
Acceptance criteria
Additional context
No response
Links to other issues
No response
The text was updated successfully, but these errors were encountered: