Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Admin: Show only fields applicable to Org Type #1042

Open
6 tasks
PaulKuykendall opened this issue Sep 19, 2023 · 2 comments
Open
6 tasks

Django Admin: Show only fields applicable to Org Type #1042

PaulKuykendall opened this issue Sep 19, 2023 · 2 comments
Labels
dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow

Comments

@PaulKuykendall
Copy link

PaulKuykendall commented Sep 19, 2023

Issue Description

Goal: When rendering these pages, show ONLY the fields which are appropriate and applicable to the Organization Type specified.

Applicability

In Django Admin, this issue applies to multiple pages.

  • - Domain Detail page, /admin/registrar/domain/{number}/change/
  • - Domain Application Detail page, /admin/registrar/domainapplication/{number}/change/
  • - Domain Information Detail page, /admin/registrar/domaininformation/{number}/change/

Problem:

When editing domain information, all available fields are exposed to the user, regardless of org type, including those fields which are not relevant nor appropriate for the selected org type.

Improvement:

Instead, only show the fields applicable to chosen org type.

Test Case:

Given a user is viewing or editing Domain Information
When the user selects an Organization Type
Then is should be clear to the user, which fields are required/applicable to that organization type.

Constraint:

Avoid making Django Admin any more javascript dependent.

Acceptance Criteria:

For the above mentioned pages, when the Org Type is:

  • "Federally recognized tribe," "State recognized tribe," and "Tribe name" are only displayed/editable when the Organization type is Tribal
  • "Federal Agency" and "Federal Type" are only displayed/editable when the Organization type is Federal.
  • These changes have been applied to all the pages listed above in Applicability

Additional Context (optional)

No response

Issue Links

This originated from #935

@PaulKuykendall PaulKuykendall added design issue is for the design team later Not MVP labels Sep 19, 2023
@PaulKuykendall PaulKuykendall changed the title Django Admin: Show fields applicable to Org Type on Domain Information page Django Admin: Show only fields applicable to Org Type Sep 21, 2023
@Katherine-Osos Katherine-Osos moved this from 👶 New to 🍦 Backlog in .gov Product Board Jan 8, 2024
@Katherine-Osos Katherine-Osos added dev issue is for the dev team and removed design issue is for the design team labels Feb 12, 2024
@PaulKuykendall PaulKuykendall removed the later Not MVP label Feb 26, 2024
@PaulKuykendall PaulKuykendall removed their assignment Feb 27, 2024
@PaulKuykendall
Copy link
Author

@rachidatecs - can you comment on the relative difficulty in making DjA display fields conditionally??

@PaulKuykendall
Copy link
Author

PaulKuykendall commented Feb 27, 2024

The LOE for this seems high, and would create more of a reliance on JS in DjA. Not a good thing.
ALSO - this is NOT particularly valueable, rather it just reduces the "nuisance" of seeing this fields under conditions where they are irrelevant. Moving to the FUTURE Analyst enhancements.

@katypies katypies moved this from 🍦 Backlog to 🚗 Parking Lot in .gov Product Board Aug 2, 2024
@katypies katypies added the Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow
Projects
Status: 🚗 Parking Lot
Development

No branches or pull requests

3 participants