You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That is a good point, although we devs tend to have a hard time knowing or remembering what normies know and don't know. It's definitely something to keep in mind when reviewing other devs' pull requests.
This triggered a thought: Should we have a document in our dev guide that talks about reviewing PRs and has a list of thangs like this to keep in mind? I think such a document could be useful, but could also turn into a list that is too long and random to be of any use. Does 18F or TTS have a document we can borrow/steal?
That is a good point, although we devs tend to have a hard time knowing or remembering what normies know and don't know. It's definitely something to keep in mind when reviewing other devs' pull requests.
This triggered a thought: Should we have a document in our dev guide that talks about reviewing PRs and has a list of thangs like this to keep in mind? I think such a document could be useful, but could also turn into a list that is too long and random to be of any use. Does 18F or TTS have a document we can borrow/steal?
Originally posted by @jsf9k in cisagov/skeleton-docker#51 (comment)
The text was updated successfully, but these errors were encountered: