Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide guide policy for PRs that need to wait #37

Open
hillaryj opened this issue Nov 18, 2020 · 3 comments
Open

Decide guide policy for PRs that need to wait #37

hillaryj opened this issue Nov 18, 2020 · 3 comments
Assignees
Labels
question This issue is a request for information or needs discussion

Comments

@hillaryj
Copy link
Contributor

hillaryj commented Nov 18, 2020

I've seen two major schools of thought on how to indicate that a PR that GitHub thinks is ready to merge actually needs to wait. This status is different than draft PRs because the code is ready to be reviewed/merged but may need other PRs to be completed before merging can be done, i.e. for coordinating a new feature across several repositories.

  1. Preface the title with [HOLD] or another keyword
  2. Include a label i.e. DO NOT MERGE or with the feature i.e. HOLD: COOL FEATURE or (preferably for standardizing) use the blocked label

Since we want to standardize repository labels in cisagov/.github#7, I'm recommending we adopt the title-preface method. We'll incorporate the results of discussion here into the team guide.

@hillaryj hillaryj added the question This issue is a request for information or needs discussion label Nov 18, 2020
@hillaryj hillaryj self-assigned this Nov 18, 2020
@dav3r
Copy link
Member

dav3r commented Nov 18, 2020

I do like having a label for this, mainly because it catches my eye when I look at the list of PR reviewers (something I do just prior to merging), but I'm sure I could get used to the title-preface method also.

@hillaryj
Copy link
Contributor Author

We could always do both - [HOLD] in the title and blocked as a label, perhaps?

@jsf9k
Copy link
Member

jsf9k commented Nov 18, 2020

I suggest the title thang, and possibly applying the blocked label as well. This is an out of the ordinary circumstance, so having two ways to flag such PRs will help prevent mistakes without being burdensome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question This issue is a request for information or needs discussion
Projects
None yet
Development

No branches or pull requests

3 participants