Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom validator support #23

Open
SirMullich opened this issue Nov 8, 2019 · 3 comments
Open

Custom validator support #23

SirMullich opened this issue Nov 8, 2019 · 3 comments

Comments

@SirMullich
Copy link
Contributor

Add support of custom validators. Currently, Everit supports custom validators
@SirMullich SirMullich changed the title Customer validator support Custom validator support Nov 8, 2019
@SirMullich
Copy link
Contributor Author

Suggestions are welcome for #22

@travisbrown
Copy link
Member

I'm reluctant to move forward with this given #8 and the fact that this introduces closer coupling with Everit. Circe already provides extensive facilities for validation, and the primary goal of this library is to support JSON Schema validation—not to be a one-stop validation solution.

@SirMullich
Copy link
Contributor Author

I agree that this introduces closer coupling with Everit. Should I close this issue for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@travisbrown @SirMullich