Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sbt circe plugin #423

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

lorandszakacs
Copy link

@lorandszakacs lorandszakacs commented Sep 20, 2022

  • title says it all, use the new sbt-circe-io plugin 😄. Depends on initial implementation of plugin sbt-circe-org#1
  • removed configs keys that sbt was warning me about
  • not entirely sure if Mima needs more config 🤷
  • enables warnings, but disables fatal CI warning. We should fix all at some point
  • use the sama scalafmt.conf as circe
  • inherit scalafix w/ organizeImports from the sbt plugin
  • ran the prePR command, which is the only thing that modified source code outside of the build

Also, the current build definitely uses the equivalent of ThisBuild / tlSonatypeUseLegacyHost := false (LE: I meant the exact opposite. Booleans are hard). Not sure if the circe org can publish to new hosts though.

I abstained from upgrading various versions in this PR 😅 I'll follow-up with that if thisi gets merged.

@lorandszakacs lorandszakacs marked this pull request as draft September 21, 2022 11:47
@lorandszakacs
Copy link
Author

On hold until we get the org plugin out the door. After that I'll update this PR to use that instead (it's also how I'm testing the plugin locally)
circe/sbt-circe-org#1

@lorandszakacs lorandszakacs changed the title Use sbt typelevel Use sbt circe plugin Sep 24, 2022
@zmccoy
Copy link
Member

zmccoy commented Feb 6, 2023

Hi @lorandszakacs, do you have any more commits for this that you need to push up? Just want to make sure this gets over the line if someone needs to pick it up. Thanks!

@nafg
Copy link

nafg commented Apr 24, 2023

Any way I can help with this?

@zmccoy zmccoy marked this pull request as ready for review April 26, 2023 21:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 69.23% and project coverage change: +49.64 🎉

Comparison is base (799c1b9) 31.33% compared to head (dd2a40e) 80.98%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #423       +/-   ##
===========================================
+ Coverage   31.33%   80.98%   +49.64%     
===========================================
  Files           8        6        -2     
  Lines         584      163      -421     
  Branches       63       23       -40     
===========================================
- Hits          183      132       -51     
+ Misses        401       31      -370     
Flag Coverage Δ
2.12.15 80.86% <69.23%> (?)
2.13.8 76.10% <61.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...o/circe/derivation/annotations/Configuration.scala 64.70% <ø> (ø)
...-2.12/io/circe/derivation/ScalaVersionCompat.scala 100.00% <ø> (ø)
...-2.13/io/circe/derivation/ScalaVersionCompat.scala 100.00% <ø> (ø)
.../src/main/scala/io/circe/derivation/renaming.scala 100.00% <ø> (ø)
...la/io/circe/derivation/annotations/JsonCodec.scala 70.58% <63.63%> (-5.61%) ⬇️
...n/scala/io/circe/derivation/DerivationMacros.scala 85.98% <100.00%> (+0.26%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants