fix: Prevent IME-exiting Enter press from sending message on Safari #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On most browsers, pressing Enter to end IME composition produces this sequence of events: * keydown (keycode 229, key Processing/Unidentified, isComposing true) * compositionend * keyup (keycode 13, key Enter, isComposing false) On Safari, the sequence is different: * compositionend * keydown (keycode 229, key Enter, isComposing false) * keyup (keycode 13, key Enter, isComposing false) This causes Safari users to mistakenly send their messages when they press Enter to confirm their choice in an IME. The workaround is to treat the next keydown with keycode 229 as if it were part of the IME composition period if it occurs within a short time of the compositionend event. Fixes cinnyapp#2103, but needs confirmation from a Safari user.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Jan 21, 2025
dvcrn
reviewed
Jan 22, 2025
| @@ -47,6 +47,7 @@ import { settingsAtom } from '../../state/settings'; | |||
| import { isMacOS } from '../../utils/user-agent'; | |||
| import { KeySymbol } from '../../utils/key-symbol'; | |||
| import { useMatrixClient } from '../../hooks/useMatrixClient'; | |||
| import { isComposing } from '../../utils/keyboard.js'; | |||
There was a problem hiding this comment.
Suggested change
| import { isComposing } from '../../utils/keyboard.js'; | |
| import { isComposing } from '../../utils/keyboard; |
| @@ -27,6 +27,7 @@ import { useKeyDown } from '../../hooks/useKeyDown'; | |||
| import { openSearch } from '../../../client/action/navigation'; | |||
| import { useMatrixClient } from '../../hooks/useMatrixClient'; | |||
| import { factoryRoomIdByActivity } from '../../utils/sort'; | |||
| import { isComposing } from '../../utils/keyboard.js'; | |||
There was a problem hiding this comment.
Suggested change
| import { isComposing } from '../../utils/keyboard.js'; | |
| import { isComposing } from '../../utils/keyboard'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On most browsers, pressing Enter to end IME composition produces this sequence of events:
On Safari, the sequence is different:
This causes Safari users to mistakenly send their messages when they press Enter to confirm their choice in an IME.
The workaround is to treat the next keydown with keycode 229 as if it were part of the IME composition period if it occurs within a short time of the compositionend event.
Fixes #2103, but needs confirmation from a Safari user.
Type of change
Checklist: