Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Volume also float64 instead of int64 !? #157

Closed
heiningair opened this issue Jun 15, 2024 · 5 comments · Fixed by #190
Closed

Snapshot Volume also float64 instead of int64 !? #157

heiningair opened this issue Jun 15, 2024 · 5 comments · Fixed by #190
Assignees

Comments

@heiningair
Copy link

Is your feature request related to a problem? Please describe.
When using indicators, like e.g. trend.NewVwmafloat64 and executing a Compute on it, channels need to be passed in (per Type definition) they need to match float64 in this case for closings and volume.

Describe the solution you'd like
When giving the Volume in the Snapshot type a float64 value instead of the int64 it would make things easier to work with, wouldnt it?

@cinar
Copy link
Owner

cinar commented Jun 17, 2024

Let me see.. I should be able to change it.

@heiningair
Copy link
Author

that would be awesome. I assume that various ohlc structures out there handling that differently, but for calculations within this library structure aka the indicators, it might be easier...

@HouzuoGuo
Copy link
Contributor

Thanks cinar!

Changing the volume data type to float64 would be immensely useful for assets traded in fractions (e.g. cryptocurrencies).

@cinar cinar self-assigned this Jul 19, 2024
@cinar
Copy link
Owner

cinar commented Jul 19, 2024

I'll take care of it today quickly. I feel it will be an easy one.

@cinar
Copy link
Owner

cinar commented Jul 20, 2024

I made the change. You can use it starting from Release v2.1.0. Please let me know if I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants