-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot Volume also float64 instead of int64 !? #157
Comments
Let me see.. I should be able to change it. |
that would be awesome. I assume that various ohlc structures out there handling that differently, but for calculations within this library structure aka the indicators, it might be easier... |
Thanks cinar! Changing the volume data type to float64 would be immensely useful for assets traded in fractions (e.g. cryptocurrencies). |
I'll take care of it today quickly. I feel it will be an easy one. |
I made the change. You can use it starting from Release v2.1.0. Please let me know if I missed anything. |
Is your feature request related to a problem? Please describe.
When using indicators, like e.g. trend.NewVwmafloat64 and executing a Compute on it, channels need to be passed in (per Type definition) they need to match float64 in this case for closings and volume.
Describe the solution you'd like
When giving the Volume in the Snapshot type a float64 value instead of the int64 it would make things easier to work with, wouldnt it?
The text was updated successfully, but these errors were encountered: