Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish release images #2755

Closed
michi-covalent opened this issue Aug 14, 2024 · 2 comments · May be fixed by #2770
Closed

publish release images #2755

michi-covalent opened this issue Aug 14, 2024 · 2 comments · May be fixed by #2770
Labels
good first issue Good for newcomers stale

Comments

@michi-covalent
Copy link
Contributor

publish cilium-cli release images. make it multi arch with arm64 and amd64. probably makes sense to create a new repo quay.io/cilium/cilium-cli instead of using https://quay.io/repository/cilium/cilium-cli-ci.

context: https://cilium.slack.com/archives/C1MATJ5U5/p1723450193483599
@michi-covalent michi-covalent added the good first issue Good for newcomers label Aug 14, 2024
@leppeK leppeK mentioned this issue Aug 14, 2024
Open
leppeK added a commit to leppeK/cilium-cli that referenced this issue Aug 20, 2024
@leppeK
publish images: amd64/arm64 images containing cli only
a2e713c 
There was no prebuilt image available for multiple architectures,
this provides an image from scratch only containing cilium-cli
binary.

This ensures that the image can be used directly as a standalone
solution or included within other containers

example dockerfile
---
FROM quay.io/cilium/cilium-cli:tag as cilium
FROM exampleimage
COPY --from=cilium /usr/local/bin/cilium /usr/local/bin/cilium
---

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
@leppeK leppeK mentioned this issue Aug 20, 2024
Closed
leppeK added a commit to leppeK/cilium-cli that referenced this issue Aug 20, 2024
@leppeK
publish images: amd64/arm64 images containing cli only
d24e654 
There was no prebuilt image available for multiple architectures,
this provides an image from scratch only containing cilium-cli
binary.

This ensures that the image can be used directly as a standalone
solution or included within other containers

example dockerfile
---
FROM quay.io/cilium/cilium-cli:tag as cilium
FROM exampleimage
COPY --from=cilium /usr/local/bin/cilium /usr/local/bin/cilium
---

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
@leppeK leppeK mentioned this issue Aug 20, 2024
Open
leppeK added a commit to leppeK/cilium-cli that referenced this issue Aug 22, 2024
@leppeK
Build desired target with a buildargument
bddd984 
This way we are not diverging in multiple dockerfiles and we can choose between two targets:
- cilium-cli-ci The original target based on ubuntu and the default
- cilium-cli Only contains the cilium cli based on scratch

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
leppeK added a commit to leppeK/cilium-cli that referenced this issue Aug 23, 2024
@leppeK
reference the correct file.
5dc0d10 
@asauber pointed out i referenced a Dockerfile that does not exist
anymore

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
leppeK added a commit to leppeK/cilium-cli that referenced this issue Aug 23, 2024
@leppeK
publish images: amd64/arm64 images containing cli only
af00213 
There was no prebuilt image available for multiple architectures,
this provides an image from scratch only containing cilium-cli
binary.

This ensures that the image can be used directly as a standalone
solution or included within other containers

example dockerfile
---
FROM quay.io/cilium/cilium-cli:tag as cilium
FROM exampleimage
COPY --from=cilium /usr/local/bin/cilium /usr/local/bin/cilium
---

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
leppeK added a commit to leppeK/cilium-cli that referenced this issue Aug 23, 2024
@leppeK
Build desired target with a buildargument
5db523c 
This way we are not diverging in multiple dockerfiles and we can choose between two targets:
- cilium-cli-ci The original target based on ubuntu and the default
- cilium-cli Only contains the cilium cli based on scratch

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
leppeK added a commit to leppeK/cilium-cli that referenced this issue Aug 23, 2024
@leppeK
reference the correct file.
5f96dce 
@asauber pointed out i referenced a Dockerfile that does not exist
anymore

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
leppeK added a commit to leppeK/cilium-cli that referenced this issue Sep 18, 2024
@leppeK
publish images: amd64/arm64 images containing cli only
7bad135 
There was no prebuilt image available for multiple architectures,
this provides an image from scratch only containing cilium-cli
binary.

This ensures that the image can be used directly as a standalone
solution or included within other containers

example dockerfile
---
FROM quay.io/cilium/cilium-cli:tag as cilium
FROM exampleimage
COPY --from=cilium /usr/local/bin/cilium /usr/local/bin/cilium
---

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
leppeK added a commit to leppeK/cilium-cli that referenced this issue Sep 18, 2024
@leppeK
Build desired target with a buildargument
c69da57 
This way we are not diverging in multiple dockerfiles and we can choose between two targets:
- cilium-cli-ci The original target based on ubuntu and the default
- cilium-cli Only contains the cilium cli based on scratch

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
leppeK added a commit to leppeK/cilium-cli that referenced this issue Sep 18, 2024
@leppeK
reference the correct file.
8aec284 
@asauber pointed out i referenced a Dockerfile that does not exist
anymore

Fixes: cilium#2755

Signed-off-by: Merijn Keppel <[email protected]>
leppeK added a commit to leppeK/cilium-cli that referenced this issue Sep 30, 2024
@leppeK
Prepare for cilium#2755 - Dockerfile only
9ea0ba9 
Only the Dockerfile for now as discussed with @michi-covalent because it
will diverge everytime

taken from the original commit:

--
This way we are not diverging in multiple dockerfiles and we can choose
between two targets:
- cilium-cli-ci The original target based on ubuntu and the default
- cilium-cli Only contains the cilium cli based on scratch
--

Signed-off-by: Merijn Keppel <[email protected]>
michi-covalent pushed a commit that referenced this issue Sep 30, 2024
@leppeK @michi-covalent
Prepare for #2755 - Dockerfile only
6e326ee 
Only the Dockerfile for now as discussed with @michi-covalent because it
will diverge everytime

taken from the original commit:

--
This way we are not diverging in multiple dockerfiles and we can choose
between two targets:
- cilium-cli-ci The original target based on ubuntu and the default
- cilium-cli Only contains the cilium cli based on scratch
--

Signed-off-by: Merijn Keppel <[email protected]>
@github-actions github-actions bot mentioned this issue Oct 6, 2024
Open
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Oct 13, 2024
@github-actions GitHub Actions
Copy link

This issue has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
@leppeK leppeK mentioned this issue Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers stale
Projects
Good First Issues
Status: Done
Milestone
No milestone
1 participant
@michi-covalent