diff --git a/benchmarks/README.md b/benchmarks/README.md index 8cf556aefa72..35aace07781e 100644 --- a/benchmarks/README.md +++ b/benchmarks/README.md @@ -53,9 +53,10 @@ python xla/benchmarks/experiment_runner.py \ You can change the flags to add the configurations you are interested in. The `experiment_runner.py` will expand the options to all supported configurations. For example, in the case above, it will consider all the possible combinations -among the flags `--dynamo`, `--xla`, and `--test`, 4 of which are supported: +among the flags `--dynamo`, `--xla`, and `--test`, 5 of which are supported: - `dynamo=openxla_eval`, `xla=PJRT`, `test=eval` + - `dynamo=openxla`, `xla=PJRT`, `test=eval` - `dynamo=openxla`, `xla=PJRT`, `test=train` - `dynamo=inductor`, `xla=None`, `test=eval` - `dynamo=inductor`, `xla=None`, `test=train` diff --git a/benchmarks/benchmark_experiment.py b/benchmarks/benchmark_experiment.py index 21679594d2fa..0de425bdc3ec 100644 --- a/benchmarks/benchmark_experiment.py +++ b/benchmarks/benchmark_experiment.py @@ -88,8 +88,7 @@ def is_available(self, experiment_config): if experiment_config["dynamo"] == "openxla_eval" and not ( experiment_config["xla"] and experiment_config["test"] == "eval"): return False - if experiment_config["dynamo"] == "openxla" and not ( - experiment_config["xla"] and experiment_config["test"] == "train"): + if experiment_config["dynamo"] == "openxla" and not experiment_config["xla"]: return False if (experiment_config["xla"] and not is_xla_device_available(experiment_config["accelerator"].upper())): diff --git a/benchmarks/experiment_runner.py b/benchmarks/experiment_runner.py index 947e1a91de3f..487ba8d85e9a 100644 --- a/benchmarks/experiment_runner.py +++ b/benchmarks/experiment_runner.py @@ -501,7 +501,7 @@ def parse_args(args=None): "--collect-full-output", action="store_true", help="""Whether to collect full output for training. Set this to true if we - want to verify the numerical correctness of graidents. But that may + want to verify the numerical correctness of gradients. But that may cause time measurement not accurate""", )