Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Ability to put certain armour effects onto different sets of armour #73

Open
7z99 opened this issue Mar 9, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@7z99
Copy link

7z99 commented Mar 9, 2023

Is your feature request related to a problem? Please describe.

I don't think there's a significant issue but I do sometimes find it disappointing when I find a cool looking set of armour only for it to turn out that it doesn't have effects that other (subjectively) worse-looking armour sets have. For me specifically, I love the look of the hero's armour but I want the effects from the gilded glory armour.

Describe the solution you'd like

I would like if somehow these effects could be put onto different armour. For example if you could put the glow squid set's water breathing ability onto a set of diamond armour. Ideally as we spoke about in discord, it would probably need to be configurable because implementing this could definitely be abused if not regulated.

I have a few ideas for potential implementations, but for the most plausible implementation, you could put a piece of armour into a smithing table or anvil, first slot would be the armour on which you want to put the effects, and in the second would be the piece from which you want the effects.

For a second plausible implementation which would take a completely different approach, allow the effects to be considered enchants so they can be transferred to a book/another piece through a mod/enchant giver.

Describe alternatives you've considered

I had a few other ideas but looking back, they may not work:
1- Same implementation as the first one but instead of smithing two pieces together, you could use a relevant item (for example for the gilded totem effect you could use the totem of undying, for hotv, a block of emerald etc).

2- Same as above but instead of a relevant item, you can just use the relevant upgrade core.

The reason those might not work is because they would then create ambiguous crafting recipes. For example, what if you wanted the gilded totem effect on a set of opulent armour?

Additional context

Repost from discord

@7z99 7z99 added the enhancement New feature or request label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants