Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Digit Parser #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertabramski
Copy link

The digit parser doesn't work with numbers formatted with a comma. Added regex to remove the comma for formatting.

The digit parser doesn't work with numbers formatted with a comma. Added regex to remove the comma for formatting.
@Mottie
Copy link
Collaborator

Mottie commented Oct 21, 2014

This change is not a good idea... some countries use the comma and decimal point the opposite of how it is used in the U.S. (e.g. € 2.156,33 or € 2 324 156,33); pull request #34 is a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants