Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS-support broken #28

Open
toadle opened this issue Mar 24, 2015 · 3 comments
Open

TLS-support broken #28

toadle opened this issue Mar 24, 2015 · 3 comments

Comments

@toadle
Copy link

toadle commented Mar 24, 2015

I tried to configure krakow using TLS like so:

    consumer = Krakow::Consumer.new(
      :nsqlookupd => 'https://api-ssl.bitly.com/v3/nsq/lookup?access_token=xxx',
      :topic => 'topic,
      :channel => 'channel',
      :connection_options => {
        :features => {
          :tls_v1 => true
        }
      }
    )

and it starts breaking like crazy.

First it misses Celluloid::IO in ssl.rb, probably because require 'celluloid/io' is missing - which is also missing in the gem's dependencies. After that it talks about wanting "a file". Couldn't find a solution for that and gave up...

@chrisroberts
Copy link
Owner

  • add ssl spec coverage
  • update ksocket to support ssl context

@chrisroberts
Copy link
Owner

Have the feature wrapping updated to properly interact with the new ksocket within the krakow internals. I'm still encountering some errors when running the spec to apply the tls upgrade, but it is not consistent, so I'm still chasing down what exactly is causing it:

[nsqd] 2015/04/01 10:07:25.024139 ERROR: client(127.0.0.1:49003) - failed to read command - tls: received record with version 301 when expecting version 302

which then causes nsqd to kill the connection. Once I get that tracked down, this can get wrapped up and released.

@Soulou
Copy link

Soulou commented Sep 13, 2015

Any news on this? Difficult to deploy nsq in production if ruby clients can't use TLS..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants