-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATTENTION! Don't use this package and any forks, use sebastian/diff instead #53
Comments
@gugglegum PRs are welcomed 👍 and yes I work on it as needed. |
@gugglegum JBlond/php-diff has now namespaces |
I have my changes. https://github.com/jfcherng/php-diff
|
@JBlond I see you still develop php-diff recently. Maybe you would be interested in my repo above too. |
sebastian/diff doesn't seem to have colorized html output, and it shows the differences only as lines. Edit: jfcherng/php-diff works very well, thanks :) |
@fmonts check out JBlond/php-diff ,too |
This package (chrisboulton/php-diff) is abandoned and not supported for several years. There's 167 other packages that forked from this root repo, but they are ugly. Most of them doesn't contain any changes. Many other contain questionable changes. A small number of forks contains 1-2 fixes or addition of some functionality necessary to authors. But all these forks are very low quality. Most of forks (as of original repo) doesn't use namespaces which makes difficulties if you want to use Composer's autoloader. There is a few repos that adds namespaces, but they seems to be abandoned too. They mostly are missing "Issues" section, so nobody can report a bug. Code quality is not good enough (at least for me). No unit-tests, no docs, no UTF-8 support. And all forks are crashes with
count(): Parameter must be an array or an object that implements Countable
when you making a diff for two arrays where one of them is empty. The error is inlib/Diff/SequenceMatcher.php
insetSeq1()
andsetSeq2()
(need replaceif($a == $this->a) {
toif($a === $this->a) {
). This is very simple bug, but nobody found it and fixed.I've tried these packages:
Then I found a better alternative of all this misunderstanding -- it's sebastian/diff (https://github.com/sebastianbergmann/diff). It works little different, but it has much better code quality, actively maintaining, supported and the author is an authority in PHP world (he maintain PHPUnit). Actually previously it was a part of PHPUnit but then was factored out. So I recommend to use his package instead and forget about chrisboulton/php-diff and all its forks.
The text was updated successfully, but these errors were encountered: