Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for diffing unicode characters #14

Open
nullzero opened this issue May 31, 2013 · 1 comment
Open

Support for diffing unicode characters #14

nullzero opened this issue May 31, 2013 · 1 comment

Comments

@nullzero
Copy link

Hello! I found that this code cannot be used to diff between unicode characters. When trying to do that, the highlighted lines became blank. This issue can be fixed easily - Just use multibyte string function[1] instead of string function. Also, replace string indexing to mb_substr($str, $i, 1).

Cheers

Links
[1] - http://php.net/manual/en/ref.mbstring.php

@JBlond
Copy link

JBlond commented Feb 4, 2015

Thanks for the mb string hint. I added unicode support in JBlond/php-diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants