-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fractional Octave Smoothing #34
Comments
Hi! That's an interesting point - |
Hi Chris. I plotted the current window for center frequency One can see, the corrected window looks kind of warped in the linear frequency axis, but is symmetrical for the logarithmic plot. Moreover, the center frequency of the current window is, as stated, the arithmetic mean between the two extreme points, which is always a bit larger than the geometric mean. The geometric mean would be the right one though. I think you can solve this by defining the window on a logarithmic scale and then interpolating it to whatever the current frequency axis is (this effectively maps the correct window to the input's frequency vector). Hit me up if I wasn't clear or if you spot some mistake in my logic :) and sorry for the ugly x-axis on the logarithmic plot, I got bored of fighting with matplotlib for such a tiny thing hahaha PS: Here's a nice paper explaining the topic more in depth |
Hi! I was looking at the implementation of the fractional octave smoothing function and stumbled across this line.
spaudiopy/spaudiopy/process.py
Line 404 in 5f8af85
I believe it has a bug because the spectrum is expected to be linearly-spaced. This window definition will have linear-axis symmetry but not the log-axis one, which is expected for the fractional octave smoothing (the highest point of the window lies in the arithmetic mean between the indices, but the geometric mean would be the right one...)
The text was updated successfully, but these errors were encountered: