You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If not, we could optionally add simple-icons as a submodule rather than cloning the icons. I think I'd still prefer to clone, though, given we don't need the entire repo contents.
We can then include all of these icons in the built package, distributing them with the workflow along with any required customisations to apply colours.
In mirroring all of these icons, we avoid the need to perform slow icon searching from multiple sources at import runtime as we already have a full, local DB of icons.
> time python3 main.py get_accounts
This takes anywhere between 500-1200ms.
First run:
Took 0.873 seconds
Second run:
Took 0.395 seconds
As can clearly be seen,
simplepycons
is the real slowdown here.My plan (when I get the time and motivation 👀) is to rip out
simplepycons
, replacing it as follows (assuming licencing allows - haven't checked):If customisations to the SVG are required to add colour customisations, create a GHA workflow to mirror the contents of simple-icons/simple-icons/icons and the simple-icons/simple-icons/_data/simple-icons.json file into this repo and apply the necessary changes to each SVG to support colour customisation.
If not, we could optionally add simple-icons as a submodule rather than cloning the icons. I think I'd still prefer to clone, though, given we don't need the entire repo contents.
We should also mirror the contents of ente-io/ente/auth/assets/custom-icons/icons and the ente-io/ente/auth/assets/custom-icons/_data/custom-icons.json file into this repo.
We can then include all of these icons in the built package, distributing them with the workflow along with any required customisations to apply colours.
In mirroring all of these icons, we avoid the need to perform slow icon searching from multiple sources at import runtime as we already have a full, local DB of icons.
Again, this is all assuming that the licencing of both simple-icons/simple-icons and ente-io/ente allows for this plan.
The text was updated successfully, but these errors were encountered: