Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge workflows #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 19, 2021

Ref #54

As a first step towards understanding the differences between workflows, all of them are merged. The three of them are triggered by the same events anyway...

Signed-off-by: umarcor <[email protected]>
Copy link
Collaborator

@litghost litghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge if green

@litghost litghost requested a review from mithro February 19, 2021 17:06
@mithro
Copy link
Contributor

mithro commented Feb 24, 2021

I actually think that #64 will probably replace this pull request?

@umarcor
Copy link
Contributor Author

umarcor commented Feb 25, 2021

Not as is now, but yes, #64 can easily include this change. The point is not to have multiple workflows with the same events (on field). That's only useful if you/we want independent shields/badges. Otherwise, having them together is easier to navigate.

I subscribed to #64 and I will keep this just as a remainder for myself until that's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants