Skip to content

Commit

Permalink
Fix: Update link to Const/Let article
Browse files Browse the repository at this point in the history
  • Loading branch information
jdmedlock committed Aug 15, 2024
1 parent 3a0a529 commit 3f80f0c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ Tier 3 - backend or database
| Security risk with use of `eval` | High | ```* You have used the Javascript `eval` function to evaluate calculations which works. But, be aware that there are security risks associated with this function. You can learn more here --> https://www.codiga.io/blog/javascript-eval-best-practices/``` |
| Hardcoded server URL in FE | Low | ```* In `` you have hardcoded the URL to a BE server/service. This can increase maintenance time since a change to a URL will require updates to one or more source files + additional test time. Instead, consider placing URLs in environment variables so they can be modified with no code changes.``` |
| Good attributions for copied code | High | ```* Good work including attributions to code copied from other sources. This shows professional courtesy to other Developers and is much appreciated. ``` |
| Used `var` instead of `const/let` | Medium | ```* In `script.js` you have used `var` instead of `const/let`. This doesn’t impact how the app runs, but is a good defensive practice to adopt. This article explains the difference between the and why `const/let` is favored over `var` in modern JS. https://tinyurl.com/y5zj33d7``` |
| Used `var` instead of `const/let` | Medium | ```* In `script.js` you have used `var` instead of `const/let`. This doesn’t impact how the app runs, but is a good defensive practice to adopt. [This article](https://www.freecodecamp.org/news/var-let-and-const-whats-the-difference/) explains the difference between the and why `const/let` is favored over `var` in modern JS.``` |
| Nested if’s | High | ```* Some `if` statements nested too deeply (some at 3+ levels such as in ``). This can make troubleshooting problems and adding enhancements extremely difficult. One option is to split these into smaller discrete functions.``` |
| Routes, controllers & middleware logic embedded in a single server-side file. | Medium | ```* In the BE consider isolating routes, controllers, & middleware logic into separate files in your BE. This doesn’t impact how the app will run, but it will make it easier to enhance and debug as it grows.``` |
| Routes, controllers & middleware logic separated into different files | Medium | ```* In the BE you have done a good job of isolating routes, controllers, & middleware logic into separate files in your BE. This doesn’t impact how the app will run, but it will make it easier to enhance and debug as it grows.``` |
Expand Down

0 comments on commit 3f80f0c

Please sign in to comment.