Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking on the filter or search UI will trigger map movement #46

Open
amy-corson opened this issue Dec 12, 2022 · 2 comments
Open
Labels
good first issue Good for newcomers

Comments

@amy-corson
Copy link
Collaborator

Interacting with the filter container or the search container also registers as interacting with the map, which can lead to the map changing when the user does not intend for it to. For example, if you were selecting and deselecting a filter quickly, the map would register as a double click and it would zoom to a region of the map. This is especially annoying on mobile.

This could be a blunt fix (disable map movement when the search or filter is open) or a fix with a bit more finesse (clicking on the search/filter UI does not register on the map (e.preventDefault??)) (These are just some ideas, it may take a bit more research to figure out the exact right approach!)

@amy-corson amy-corson added the good first issue Good for newcomers label Dec 12, 2022
@adrianmarinwork
Copy link

Hello, I would like to take care or this issue.

@jae-the-castaway
Copy link
Contributor

I' d like to be assigned to this issue. I put Filterand Search component out of the MapContainer. and the double click in those components don't zoom the map anymore. I'd love to test more and make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants