refactor: windows elevation

[jolexxa]

@AdrasteonDev can you review this? I've refactored the Windows elevation, but I need to run testing on Windows still.

[AdrasteonDev]

I don't know if you've been able to test it on Windows, so for information, here's how things work with my PR (without your new modifications).

After a dialog to accept the elevation, a new window opens.

[AdrasteonDev]

Unfortunately, the two changes you mentioned above to redirect the output are not possible and throw an exception.

According to the doc:

You must set UseShellExecute to false if you want to set RedirectStandardOutput to true. Otherwise, reading from the StandardOutput stream throws an exception.

I have to set UseShellExecute to true, otherwise the Runas verb is not taken into account.

I tried to hide the new window and redirect the output, without success.

[AdrasteonDev]

I've added a commit to this branch for the changes I had to add to your code to make it work. Let me know if you want me to create a pull request to refactor/win-elevation with these changes.

By the way, well done for adding IWindowsElevationEnabled, it's cleaner that way!

[jolexxa]

@AdrasteonDev Hey thanks! I did not have time last night to test on Windows, so I'm super grateful for all the help. By all means, open a PR into this branch and we'll get this one fixed with your corrections!

[AdrasteonDev]

I created PR #53 with the change I described

[jolexxa]

@AdrasteonDev Any final changes? If it's looks good to you, we can get this merged and released.

[AdrasteonDev]

It looks good to me, I don't have any additional changes to make. Thanks for the time spent reviewing this PR :)