Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rollforward to Major #40

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Set rollforward to Major #40

merged 1 commit into from
Nov 20, 2023

Conversation

paulloz
Copy link
Contributor

@paulloz paulloz commented Nov 20, 2023

Hi 👋
Changing the rollforward, to be able to run the tool when you only have .net>6 installed.

@jolexxa
Copy link
Member

jolexxa commented Nov 20, 2023

Didn't realize this had to also be in the CSProj, thought it had to be in global.json. Thanks!!

@paulloz
Copy link
Contributor Author

paulloz commented Nov 20, 2023

I missed the fact there was a global.json file defined. AFAIK it serves a different purpose.

Using a global.json file ensures the SDK used when running CLI commands is of a specific version. Looking at the current config, here it means that even if we're targeting net6, we want to use at least the 7.0.302 SDK. I'm not sure if it is the desired behaviour.

The value we set in the .csproj files configures what runtime is acceptable for the application (because tools aren't self-contained). You can see more at https://learn.microsoft.com/en-us/dotnet/core/versions/selection#framework-dependent-apps-roll-forward

@jolexxa jolexxa merged commit f7b0fa1 into chickensoft-games:main Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants