Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clones old version from github #2

Open
iedmrc opened this issue May 19, 2019 · 2 comments
Open

Clones old version from github #2

iedmrc opened this issue May 19, 2019 · 2 comments

Comments

@iedmrc
Copy link

iedmrc commented May 19, 2019

Hi,
I have 2 questions:

  1. Why it clones an old version of the vroom-express ?
root@77141ce07260:/vroom-express/src# ls -la
total 12
drwxr-xr-x 2 root root 4096 Jan 24 10:11 .
drwxr-xr-x 5 root root 4096 Jan 24 10:12 ..
-rw-r--r-- 1 root root 3952 Jan 24 10:11 index.js
root@77141ce07260:/vroom-express/src# 

As you see, inside the /vroom-express/src directory in the container, there is no config.js eventhough remote source has it.

  1. Why you expose either port 5000 ?
EXPOSE 5000
EXPOSE 3000

Isn't the container just running the vroom-express server?

Thanks!

@chesty
Copy link
Owner

chesty commented May 20, 2019

Hi iedmrc,

I used to use this in a previous job and I shared it in case others found it useful, I don't think anyone did, I don't think anyone was using it and now I no longer use it so I haven't been keeping it up to date, that might explain the old version. To be honest, I've forgotten bits and pieces for the hows and whys and as you can see it wasn't highly documented.

It wasn't just vroom-express, it was also vroom. There was a new release of vroom many months ago that was incompatible with vroom-express, I can't remember the details but I had to pin to an older version of vroom until vroom-express got updated. I haven't updated this repo since pinning to the older vroom.

I might update it sometime in the future because I still really enjoy using openstreetmaps, but right now I don't have any plans.

You might be better of looking to see if there's a better docker image out there, if not maybe create one yourself, feel free to copy any bits from this repo you find useful.

@iedmrc
Copy link
Author

iedmrc commented May 20, 2019

Thanks @chesty
I did create a new repo by myself. Anyone who needs can check out my profile.

If you no longer maintain the repository, I suggest you archive the repo or indicate it in the description/readme.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants