Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template documentation + example. #8

Open
chemoish opened this issue Jun 15, 2016 · 0 comments
Open

Template documentation + example. #8

chemoish opened this issue Jun 15, 2016 · 0 comments

Comments

@chemoish
Copy link
Owner

https://github.com/chemoish/videojs-chapter-thumbnails/blob/master/src/videojs-chapter-thumbnail.js#L45 is generically specified as a {Object}, but its really more of a {string} that gets throw to the label of the VjsMenuItem.

Also add example, as its difficult to follow the flow of the code and the layers of abstraction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chemoish