Remove 'attributes'

[jkeiser]

It's a little bit confusing that

attribute 'x', 'y'

does not modify other attributes,

but attributes 'x' => 'y'

removes all other attributes.

[johnewart]

Why remove it? What about making it a plural of attribute which I think people would expect?

[jkeiser]

If attributes 'x' => 'y' is going to become exactly the same as attribute 'x', 'y' then I just don't see too many reasons to have both.

[johnewart]

What about attributes {'x' => 'y', 'q' => 'p', 'name' => 'samwise'}

[jkeiser]

Yep, that's the same as attributes 'a' => 'b', 'c' => 'd'. If the only difference between these is the plurality, then we should just let people write "I want one attribute" as attributes 'a' => 'b'.

I am flipping my feeling now to removing "attribute" instead, fyi :)

[johnewart]

I would agree - and if you want the old effect of attributes being authoritative you could just use complete

[lamont-granquist]

It definitely feels more declarative to have an attributes property that fully specifies the attributes Mash, so the title of this feels certainly wrong.

[lamont-granquist]

IDK about removing attribute either, closing this, presumably its not super important given how stale of an issue it is.