Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out the rspec helpers into a chef-rspec gem #103

Open
lamont-granquist opened this issue Mar 31, 2016 · 1 comment
Open

Break out the rspec helpers into a chef-rspec gem #103

lamont-granquist opened this issue Mar 31, 2016 · 1 comment

Comments

@lamont-granquist
Copy link
Contributor

Should probably live with chef/chef or follow the same release coordination as chef/chef and ohai will going forwards.

Having the rspec helpers in cheffish is weird as hell. Even the README.md makes it clear that its weird "here's a pile of resources... oh BTW here some 'bonus' rspec helpers...." WTF?

Now cheffish is pulled into chef/chef because of the dep that chef/chef's integration tests have on cheffish's rspec helpers which is another tangled nightmare of tightly-coupled dependencies.

And most likely since there's apparently not a lot of unit testing around the rspec helpers (at least I was able to break the tests that use them in chef/chef without breaking any spec tests in this repo) that suggests that the compatibility between the rspec helpers and old versions of chef is most likely a lie -- certain its untested and at any point may become a lie.

@thommay
Copy link
Contributor

thommay commented Apr 1, 2016

yeah, let's pull it into a separate gem under chef/chef and version and pin the same way as for chef-config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants