Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vault_admins/ADMINS to be a group, not a specific user. #195

Open
TonyLovesDevOps opened this issue Jan 27, 2016 · 3 comments
Open
Labels
Type: Enhancement Adds new functionality.

Comments

@TonyLovesDevOps
Copy link

TonyLovesDevOps commented Jan 27, 2016

We want to specify a group of users, rather than individual users, as a parameter for who should have access to a vault.

e.g. given the group 'vault-administrators', which contains users 'foo, bar, baz' we'd like to be able to specify in knife.rb:

# In knife.rb
knife[:vault_admins] =     'vault-administrators'
# Or, run as a command
knife vault update my_awesome_vault awesome_vault_item -A vault-administrators

Instead of what we need to do today:

# In knife.rb
knife[:vault_admins] =     [ 'foo', 'bar', 'baz' ]`
# Or, run as a command
knife vault update my_awesome_vault awesome_vault_item -A 'foo,bar,baz'

This would greatly simplify configuration for us; instead of needing to keep track of what the current admin list is everywhere we use knife, we could manage it in one place on the chef server.

@TonyLovesDevOps
Copy link
Author

I've worked around this for now by placing this in my knife.rb:

knife[:vault_admins] = Chef::Knife.new.rest.get_rest("groups/admins")["users"].reject{|u| u == 'pivotal'}

@thommay thommay added Type: Enhancement Adds new functionality. and removed enhancement labels Jan 25, 2017
@andrewelizondo
Copy link

👍

@themaroqa
Copy link

Is there any chance to see this implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants