Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHEF-1533 Add check for co-located generator and cookbook #225

Merged
merged 5 commits into from
Jun 19, 2023
Merged

CHEF-1533 Add check for co-located generator and cookbook #225

merged 5 commits into from
Jun 19, 2023

Conversation

vkarve-chef
Copy link
Collaborator

@vkarve-chef vkarve-chef commented Jun 2, 2023 •
edited
Loading

Description

Specifying a cookbook generator in the same path as the intended cookbook results in errors. Since this isn't good practice, the idea here is to check sooner and bail out.

Related Issue

#61

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@vkarve-chef vkarve-chef requested review from a team as code owners June 2, 2023 17:23
@vkarve-chef vkarve-chef changed the title Add check for co-located generator and cookbook CHEF-1533 Add check for co-located generator and cookbook Jun 2, 2023
@vkarve-chef vkarve-chef marked this pull request as draft June 2, 2023 17:29
@vkarve-chef
fix tests, one pending
3251947 
Signed-off-by: Vikram Karve <[email protected]>
@sonarqube-for-infrastructure-prod
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@vkarve-chef vkarve-chef marked this pull request as ready for review June 7, 2023 16:38
@vkarve-chef vkarve-chef marked this pull request as draft June 7, 2023 16:38
@vkarve-chef vkarve-chef closed this Jun 7, 2023
@vkarve-chef vkarve-chef reopened this Jun 7, 2023
@vkarve-chef vkarve-chef marked this pull request as ready for review June 7, 2023 16:43
@vkarve-chef
rubocop fix
1a469e7 
Signed-off-by: Vikram Karve <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vkarve-chef vkarve-chef merged commit ef99487 into main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiqueps ashiqueps ashiqueps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarve-chef @ashiqueps