Relax constraint on diff-lcs < 1.4 #259
Labels
Status: Untriaged
An issue that has yet to be triaged.
Comments
|
Ahah @nikhil2611 I see you are working on a major version release, do you think we could ship such "breaking" change? |
Annih
added a commit
to criteo-forks/chef-cli
that referenced
this issue
Jan 24, 2025
The version 1.3 is buggy, the only issue for chef-cli is that now the diff command will return valid diff outputs :) See chef#259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Enhancement
In June 2020, a bug report has been created on diff-lcs about compat issue with
chef-cli: halostatue/diff-lcs#65Since the, a
< 1.4.0constraint has been added tochef-clidependency ondiff-lcs.I want to relax this constraint and allow the use of recent versions like
1.5.1because it fixes actual bugs in the diff computation.It seems the only use of
diff-lcsis for thechef-cli diffcommand; I personnally don't think it is a big deal to finally have proper diff output.If you think
Describe the Need
Any ruby user depending on
chef-cliis currently blocked on old buggy deps :(Current Alternative
Different
Gemfile... yeah! 👎🏻Can We Help You Implement This?
I can submit a PR to remove the constraints, but you may want a Breaking change release, I don't know, let me know!
The text was updated successfully, but these errors were encountered: