Add input for setting docker registry for microk8s #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkandersson
approved these changes
Dec 12, 2023
jdkandersson
approved these changes
Dec 12, 2023
|
i'd REALLY like @neoaggelos to take a look at this but he may not have a moment to do so. |
neoaggelos
suggested changes
Dec 12, 2023
addyess
force-pushed
the
microk8s-docker-registry
branch
from
7d846a2
to
500ab08
Compare
addyess
reviewed
Dec 12, 2023
addyess
reviewed
Dec 13, 2023
src/bootstrap/index.ts
Outdated
| @@ -151,6 +174,7 @@ async function run() { | |||
| const microk8s_group = get_microk8s_group(); | |||
| let bootstrap_constraints = core.getInput("bootstrap-constraints"); | |||
| const microk8s_addons = core.getInput("microk8s-addons") | |||
| const microk8s_docker_registry = core.getInput("microk8s-docker-registry") || process.env["DOCKERHUB_MIRROR"] | |||
There was a problem hiding this comment.
so? why is one DOCKERHUB_MIRROR and the other microk8s-docker-registry
feels to me these ought to be consistent.
Is the intent here to use a replacement oci-registry?
I kinda like either container-registry-url or oci-registry-url and just drop the "microk8s" bit.
then have the env var CONTAINER_REGISTRY_URL or OCI_REGISTRY_URL
There was a problem hiding this comment.
Updated the microk8s-docker-registry to container-registry-url in the code
jdkandersson
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workflow input for microk8s to use private docker registry.