[Bug] Gres written incorrectly when using Node model and slurmconfig editor

[dsloanm]

Bug Description

When using the slurmconfig editor with the Node model, Gres values are written out with commas separating each character of the string.

To Reproduce

Running:

from slurmutils.editors import slurmconfig
from slurmutils.models import Node

with slurmconfig.edit("slurm.conf") as config:
    node = Node(
        NodeName="ip-172-31-38-11",
        Gres="gpu:tesla_t4:1",
    )
    config.nodes.update(node.dict())

produces slurm.conf:

NodeName=ip-172-31-38-11 Gres=g,p,u,:,t,e,s,l,a,_,t,4,:,1

rather than expected:

NodeName=ip-172-31-38-11 Gres=gpu:tesla_t4:1

Environment

Running locally with the latest main commit: 60bc8e6.

Relevant log output

N/A

Additional context

No response

[NucciTheBoss]

Taking a quick peak at this issue, it's a symptom of #34 where we don't have good type checking enabled. Gres can be a comma-delimited list, which means that it's a list[str] type rather than just str. Since there's no real type checking, slurmutils will happily try to marshal a value using the assigned callback even if the value is the incorrect type.

The Gres configuration option is assigned the CommaSeparatorCallback so the value for Gres must be passed as a list:

slurmutils/slurmutils/models/option.py

Line 437 in 60bc8e6

Gres: Callback = CommaSeparatorCallback

The way to solve your issue here would be to pass the value of Gres as a list[str] rather than just a str:

from slurmutils.editors import slurmconfig
from slurmutils.models import Node

with slurmconfig.edit("slurm.conf") as config:
    node = Node(
        NodeName="ip-172-31-38-11",
        Gres=["gpu:tesla_t4:1"],
    )
    config.nodes.update(node.dict())

[dsloanm]

Can confirm using a list solves this.