Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Preseeded slurm.conf conflicts with slurm.conf retrieved from controller when in configless mode #27

Closed
jedel1043 opened this issue Jun 17, 2024 · 1 comment · Fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@jedel1043
Copy link
Contributor

Right now the snap creates an empty file at startup time. However, a small papercut of this is that if the slurmd is transitioned into configless mode, the daemon will try to load the empty file, even if the config has been already fetched from slurmctld. This adds a manual step of having to delete the file manually.

Technically this could be solved by deleting the file if the user sets the slurm.config-server option. Though, this could cause problems for users that had an extensive config there, since it would make it harder to unroll the change in case the user wants to return to the classic behaviour. Maybe this won't be a problem; the config file is replicated between the controller and all the nodes, which should be pretty easy to do manually; but I think it would be good to think about this before implementing a solution that deletes or modifies the config file.

@NucciTheBoss
Copy link
Member

I consider this a bug within in the snap. The install hook will seed an empty slurm.conf file when the snap is first installed. This file isn't actually required since the snap still needs some additional configuration before Slurm is ready to get "slurmy."

It would be better if we just created the file when an administrator actually sets a configuration parameter for slurm.conf rather than seed an empty file at install time. This then allows us to throw an error if the administrator sets a configuration parameter when slurmd is configured to run in configless/dynamic mode, and gives us the ability to automatically delete the file when configless mode is enabled.

@NucciTheBoss NucciTheBoss changed the title Decide what to do about slurm.conf on slurmd in configless mode [Bug]: Preseeded _slurm.conf_ conflicts with _slurm.conf_ retrieved from controller when in configless mode Jun 25, 2024
@NucciTheBoss NucciTheBoss changed the title [Bug]: Preseeded _slurm.conf_ conflicts with _slurm.conf_ retrieved from controller when in configless mode [Bug]: Preseeded *slurm.conf* conflicts with *slurm.conf* retrieved from controller when in configless mode Jun 25, 2024
@NucciTheBoss NucciTheBoss changed the title [Bug]: Preseeded *slurm.conf* conflicts with *slurm.conf* retrieved from controller when in configless mode [Bug]: Preseeded slurm.conf conflicts with slurm.conf retrieved from controller when in configless mode Jun 25, 2024
@NucciTheBoss NucciTheBoss added the bug Something isn't working label Jun 25, 2024
@NucciTheBoss NucciTheBoss self-assigned this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants