Fix the issue: regression since v2.1.9: nixnote2

no longer exiting cleanly (terminated by SIGABRT) robert7#208
charlescanato · Oct 24, 2023 · 49cc8dc · 49cc8dc
1 parent b3b035f
commit 49cc8dc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/gui/nbrowserwindow.cpp b/src/gui/nbrowserwindow.cpp
@@ -308,6 +308,7 @@ NBrowserWindow::NBrowserWindow(QWidget *parent) :
 NBrowserWindow::~NBrowserWindow() {
     browserThread->quit();
     while (!browserRunner->isIdle);
+    while (!browserThread->isFinished());
 
     delete browserThread;
     delete browserRunner;

diff --git a/src/nixnote.cpp b/src/nixnote.cpp
@@ -243,6 +243,7 @@ NixNote::NixNote(QWidget *parent) : QMainWindow(parent) {
 
 // Destructor to call when all done
 NixNote::~NixNote() {
+    QLOG_DEBUG() << "~NixNote: Closing threads";
     syncThread.quit();
     indexThread.quit();
     counterThread.quit();
@@ -1299,10 +1300,6 @@ void NixNote::saveOnExit() {
     saveNoteColumnPositions();
     noteTableView->saveColumnsVisible();
 
-    QLOG_DEBUG() << "saveOnExit: Closing threads";
-    indexThread.quit();
-    counterThread.quit();
-
     QLOG_DEBUG() << "Exiting saveOnExit()";
 }