Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit static files into Zenodo #513

Closed
2 of 3 tasks
holtgrewe opened this issue Jun 7, 2021 · 8 comments
Closed
2 of 3 tasks

Deposit static files into Zenodo #513

holtgrewe opened this issue Jun 7, 2021 · 8 comments
Assignees
Milestone

Comments

@holtgrewe
Copy link
Member

holtgrewe commented Jun 7, 2021

Is your feature request related to a problem? Please describe.
The download URLs turn out to be unstable. In particular, RefSeq release 105 has now moved somewhere (TM) on the NCBI servers and is not available any more at its original location.

Describe the solution you'd like
We should deposit a copy of all data on Zenodo.

  • deposit files as downloadable in Zenodo (use - to create sub directory like structure)
  • adjust the INI files to download from there
  • drop support for hg18 from INI files

Describe alternatives you've considered
Hosting the files at another location could turn out to be unstable, so Zenodo is the best solution.

Additional context
BIH should have a copy of the files in the current Jannovar release on our internal mirror servers. I'll take the files from there.

Related Tickets

@holtgrewe
Copy link
Member Author

CC @visze @pnrobinson

@holtgrewe holtgrewe self-assigned this Jun 7, 2021
@holtgrewe holtgrewe added this to the v0.35 milestone Jun 7, 2021
@holtgrewe
Copy link
Member Author

Zenodo seems to be down right now, I'll try to attach a copy of the data here.

@holtgrewe
Copy link
Member Author

OK, the files are here now inside a ZIP archive. Zenodo does not support sub directories, so we would have to put the folder structure into the file name, e.g., by replacing / by -.

https://zenodo.org/record/4906580#.YL5ExDqxWAk

@holtgrewe
Copy link
Member Author

CC #504

@pnrobinson
Copy link
Contributor

This is a good suggestion. Zenodo is a good choice for the download files.

@holtgrewe
Copy link
Member Author

@pnrobinson what do you think about slimming down things even further:

  • Provide Bash scripts for building a "data release", IOW: download upstream files and upload them into Zenodo.
  • We could then attach the .ser files here to the releases.
  • We could get rid of the code for downloading files which means less code to maintain. Instead, "download" would pull the files from Github.

@pnrobinson
Copy link
Contributor

There are multiple possible ways of doing this. I think that 99% of users would appreciate things being simple and would be happy to trust us for making the ".ser" files. When we released the first version of Jannovar, the download was reliable and simple enough, but now the upstream sources seem determined to change paths often...so, yes, I think your suggestion is great

@holtgrewe
Copy link
Member Author

INI files don't download from Zenodo but we have download scripts as described in the README.md now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants