Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to patch the module from pull requests #607

Open
mglaman opened this issue Nov 21, 2023 · 2 comments
Open

Document how to patch the module from pull requests #607

mglaman opened this issue Nov 21, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@mglaman
Copy link
Contributor

mglaman commented Nov 21, 2023

Package

next (Drupal module)

Describe the feature request

This is a mono-repo, so patching the Drupal module can be difficult as the structure doesn't match the split to Drupal.org. Provide information on how to patch from the GitHub repo.

Describe the solution you'd like

Document that patchLevel of -p3 needs to be applied for cweagans/composer-patches

        "patchLevel": {
            "drupal/core": "-p2",
            "drupal/next": "-p3"
        },

Additional context

We need #606 to prevent crashes and had to apply it somehow.

@mglaman mglaman added enhancement New feature or request triage A new issue that needs triage labels Nov 21, 2023
@mglaman
Copy link
Contributor Author

mglaman commented Dec 7, 2023

I actually have no idea where this would be go. Maybe the README? Maybe documentation? Maybe this just gets moved to a Discussion as a form of record, there.

Screenshot 2023-12-07 at 2 59 49 PM

@JohnAlbin JohnAlbin added documentation Improvements or additions to documentation and removed triage A new issue that needs triage labels Dec 13, 2023
@JohnAlbin
Copy link
Collaborator

There's a CONTRIBUTING.md doc now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants