feat: add logger middleware for dev/local environment #38
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 61.96% 67.59% +5.62%
==========================================
Files 23 23
Lines 539 503 -36
==========================================
+ Hits 334 340 +6
+ Misses 177 137 -40
+ Partials 28 26 -2 ☔ View full report in Codecov by Sentry. |
|
@martinyonatann |
martinyonatann
force-pushed
the
feat/middleware-logger
branch
from
664f3c6 to
adca0a8
Compare
martinyonatann
force-pushed
the
feat/middleware-logger
branch
from
adca0a8 to
2f88bb1
Compare
| ) | ||
|
|
||
| const ( | ||
| ENVIRONMENT_NAME_PRODUCTION = "production" |
There was a problem hiding this comment.
I think in Go the culture is not to use ALL_CAP_CASE for variables like Java world no?
There was a problem hiding this comment.
go naming conventions https://www.mohitkhare.com/blog/go-naming-conventions/
There was a problem hiding this comment.
Constant should use all capital letters and use underscore _ to separate words. Eg. INT_MAX
There was a problem hiding this comment.
other reference https://www.cnblogs.com/zhangzhihui/articles/17881312.html
There was a problem hiding this comment.
https://go.dev/talks/2014/names.slide#5
Please try to follow the official blog and its rules
Constant should use all capital letters and use underscore
_to separate words. Eg.INT_MAX
Can't have capital always as in Go, capital suggests exporting of values outside package scope
Closes #37