Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fn convert_u64_to_u256 #1523

Open
kpp opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1518
Open

Remove fn convert_u64_to_u256 #1523

kpp opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1518
Labels
M - good first issue Good for newcomers

Comments

@kpp
Copy link
Contributor

kpp commented Nov 25, 2024

Because modern version of alloy U256 implements U256::from for u64.
@kpp kpp added the M - good first issue Good for newcomers label Nov 25, 2024
@kpp kpp linked a pull request Nov 25, 2024 that will close this issue
Open
@varun-doshi
Copy link

Is this still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M - good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Erce/update core dependencies chainwayxyz/citrea
2 participants
@kpp @varun-doshi