Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default for packages without tests should be to create an image to make sure the package can be installed. #1690

Open
justinvreeland opened this issue Dec 10, 2024 · 0 comments

Comments

@justinvreeland
Copy link
Contributor

justinvreeland commented Dec 10, 2024

When you try to run melange test on a package that doesn't have a test specified some output dumps and it returns 0.

/opt/homebrew/bin/melange test font-ipa.yaml --repository-append /Users/justin/work/os/packages --keyring-append local-melange.rsa.pub --arch aarch64 --pipeline-dirs ./pipelines/ --repository-append https://packages.wolfi.dev/os --keyring-append https://packages.wolfi.dev/os/wolfi-signing.rsa.pub --test-package-append wolfi-base --debug  --source-dir ./font-ipa/
2024/12/10 12:06:20 INFO evaluating pipelines for package requirements
2024/12/10 12:06:20 INFO building test workspace in: '/var/folders/vw/5gq4f3g53y55wkv1phvjx5b00000gn/T/melange-guest-572086733-main' with apko
2024/12/10 12:06:20 INFO populating workspace /var/folders/vw/5gq4f3g53y55wkv1phvjx5b00000gn/T/melange-workspace-3965228451 from ./font-ipa/
2024/12/10 12:06:20 INFO ImgRef = 

I can understand not wanting to return non zero if melange test was empty but I think it'd make sense for an empty melange test to at least install the package you were trying to test. That seems like a sane null test for a package.

Without this I found myself scripting various alternatives that amount to make local-wolfi then apk add.... when melange could do that by default.

@justinvreeland justinvreeland changed the title melange test behavior for files without tests seems strange The default for packages without tests should be to create an image to make sure the package can be installed. Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant