Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CoinGecko links back #881

Merged
merged 20 commits into from
Nov 29, 2024
Merged

Adding CoinGecko links back #881

merged 20 commits into from
Nov 29, 2024

Conversation

TravelingTechGuy
Copy link
Contributor

With Kima TGE underway and our token becoming tradable, I added the coinGeckoId back to both mainnet and testnet files

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 3:09pm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove coingeckoIds from the testnet info? It might conflict with the one in the mainnet info. Apologies for the inconvenience.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course - no problems! Fixed!

@@ -24,7 +24,8 @@
{
"coinDenom": "KIMA",
"coinMinimalDenom": "uKIMA",
"coinDecimals": 6
"coinDecimals": 6,
"coinGeckoId": "kima"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one as well!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I removed that? Must have pushed the wrong file - let me check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check now @editaahn? Thanks! Not sure if I need to re-push.

@editaahn editaahn merged commit 7ed927b into chainapsis:main Nov 29, 2024
2 checks passed
@TravelingTechGuy
Copy link
Contributor Author

@editaahn It looks like the merge worked! I can now see the price of Kima token!
But for some reson, the 2 blockchain icons are not there - what am I missing now?
Screenshot 2024-11-29 at 1 32 16 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants