Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't create an ID and then reference it -- this is messy #139

Open
sezna opened this issue Jul 30, 2024 · 0 comments
Open

don't create an ID and then reference it -- this is messy #139

sezna opened this issue Jul 30, 2024 · 0 comments
Assignees

Comments

@sezna
Copy link
Collaborator

sezna commented Jul 30, 2024

// TODO don't create an ID and then reference it -- this is messy
let id = self.generic_type(generic_name);
SpecificType::Ref(id)
},
petr_resolve::Type::Sum(tys) => SpecificType::Sum(tys.iter().map(|ty| self.to_petr_type(ty)).collect()),
petr_resolve::Type::Literal(l) => SpecificType::Literal(l.clone()),


This issue was generated by todo-issue based on a TODO comment in 6c2873b. It's been assigned to @sezna because they committed the code.
@sezna sezna self-assigned this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant