diff --git a/.github/workflows/on_main_commit.yml b/.github/workflows/on_main_commit.yml index 65812d9..28a9dec 100644 --- a/.github/workflows/on_main_commit.yml +++ b/.github/workflows/on_main_commit.yml @@ -1,8 +1,12 @@ name: TODO check on: + pull_request: { branches: "*" } push: { branches: "main" } env: PROJECTS_SECRET: ${{ secrets.PROJECTS_SECRET }} +permissions: + contents: read + issues: write jobs: check_todos: @@ -10,4 +14,5 @@ jobs: steps: - name: TODO to Issue uses: alstr/todo-to-issue-action@v4.13.1 - + with: + TOKEN: ${{ secrets.PROJECTS_SECRET }} diff --git a/pete/src/main.rs b/pete/src/main.rs index 8606a43..f8c19b9 100644 --- a/pete/src/main.rs +++ b/pete/src/main.rs @@ -238,6 +238,7 @@ fn compile( for item in build_plan.items { let (lockfile, buf, _build_plan) = load_project_and_dependencies(&item.path_to_source)?; // TODO(alex) -- transitive dependencies, get these build plans too + // assignee: sezna let lockfile_toml = toml::to_string(&lockfile)?; let lockfile_path = path.join("petr.lock"); fs::write(lockfile_path, lockfile_toml)?; @@ -271,6 +272,7 @@ fn compile( timings.end("symbol resolution"); // TODO impl diagnostic for resolution errors + // assignee: sezna if !resolution_errs.is_empty() { dbg!(&resolution_errs); } @@ -283,6 +285,7 @@ fn compile( timings.end("type check"); // TODO impl diagnostic for type errors + // assignee: sezna if !type_errs.is_empty() { dbg!(&type_errs); } diff --git a/petr-vm/src/lib.rs b/petr-vm/src/lib.rs index b9e438b..097fbe5 100644 --- a/petr-vm/src/lib.rs +++ b/petr-vm/src/lib.rs @@ -291,11 +291,14 @@ impl Vm { self.state.registers.insert(dest, val); } - // TODO things larger than a register fn data_section_to_val( &mut self, data: &DataSectionEntry, ) -> Value { + // TODO + // need to use pointers for data larger than a reg/non-copy-types + // will involve stack memory + // assignee: sezna match data { DataSectionEntry::Int64(x) => Value(*x as u64), DataSectionEntry::String(val) => {