Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information about new OpenGL pipeline #5

Open
itsmattkc opened this issue Mar 31, 2019 · 4 comments
Open

Information about new OpenGL pipeline #5

itsmattkc opened this issue Mar 31, 2019 · 4 comments
Labels
Future Change OCIO Changes to look at for furtherocio Pipeline

Comments

@itsmattkc
Copy link

As has been mentioned previously here and on the original repo, there's a new OpenGL pipeline that's close to being merged in and these effects will need to be modified for that so I thought I'd start some discussion.

The main differences will be no common.frag or common.vert and the function will have to be in the form of:

vec4 process(vec4 color) {
    return changesTo(color);
}

rather than:

void main(void) {
    gl_FragColor = changesTo(color);
}

You can see an example of this here: https://github.com/olive-editor/olive/blob/furtherocio/effects/shaders/boxblur.frag

Additionally the compositing will all occur in scene-referred linear color space, as opposed to the current unmanaged color space. I'm not yet sure whether the effect will work in scene-linear without modifications, but it'll be something to look into once the branch is ready for merging.

@cgvirus cgvirus added the Future Change OCIO Changes to look at for furtherocio Pipeline label Mar 31, 2019
@cgvirus
Copy link
Owner

cgvirus commented Mar 31, 2019

Thanks for the heads up. I will test them when it's green.

@cgvirus
Copy link
Owner

cgvirus commented Apr 10, 2019

@itsmattkc Hi, is there any estimated time of merging OCIO implementation? So far testing with OCIIO brunch was successful. Let me know please. Thanks.

@itsmattkc
Copy link
Author

itsmattkc commented Apr 14, 2019

Hi, apologies for the late response. A caching system is currently being implemented into that branch, and after that and some testing it should be ready to merge. I would estimate around 2-3 weeks. If your effects are already compliant with the current furtherocio branch, I expect they'll remain compliant when it gets merged in. I'll update here if anything changes.

@cgvirus
Copy link
Owner

cgvirus commented Apr 15, 2019

Thanks @itsmattkc. Please let me know here as well when the merge is done. Till then I am limiting this repo only to non color effects like transitions etc. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Future Change OCIO Changes to look at for furtherocio Pipeline
Projects
None yet
Development

No branches or pull requests

2 participants