-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GNU coreutils b2sum files #9
Comments
How are external dependencies handled by this project? Right now, there do not appear to be any. Would a new one be acceptable? |
Currently, there is no mechanism to manage external dependencies. However, there is also no hard-dependency yet, as most functionality works fine with just the Python standard library. One option would be to use setuptools for dependencies, as it is already used anyway. However, I am not sure, if it is easy to specify optional dependencies. |
We could add a |
The project is also distributed via PyPI, so the dependencies should be automatically pulled when doing a |
You have to put them in As an alternative, there would be a pure-python blake2b implementation, but that is of course not competitive performance-wise. |
I am not against adding dependencies, especially, if there are some good libraries for the job. |
Since Python 3.6 hashlib suports BLAKE2 [1]. If the hashlib support is enough for supporting GNU coreutils b2sum, then I would opt for using it. In any case, please consider implementing it in cfv 3.x (currently the python3 branch), as no feature releases are planned for cfv 2.x (currently the master branch). |
Implemented in GNU coreutils with this commit: coreutils/coreutils@ea94589
The text was updated successfully, but these errors were encountered: