Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer Review #51

Open
marieakerman opened this issue Apr 4, 2018 · 1 comment
Open

Peer Review #51

marieakerman opened this issue Apr 4, 2018 · 1 comment

Comments

@marieakerman
Copy link
Collaborator

I reviewed the two homework submissions assigned to me, but both were already displaying as "Closed" before I made my comments. Are reviews still received after the pull request is closed? Should we close our homework assignments?
@bensoltoff
Copy link
Contributor

Reviews can still be seen after a pull request is closed. The TAs close a pull request after they evaluate it so we know it's been graded. You shouldn't close your own pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bensoltoff @marieakerman