Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation #3

Open
bensoltoff opened this issue Dec 9, 2016 · 0 comments
Open

Evaluation #3

bensoltoff opened this issue Dec 9, 2016 · 0 comments

Comments

@bensoltoff
Copy link
Contributor

Evaluation of final project by Benjamin Soltoff

Topic Excellent Satisfactory Needs Work
Coding style x
Coding strategy x
Presentation: graphs x
Presentation: tables x
Achievement, creativity x
Ease of access x

Remarks:

  • This is a really interesting project and put together in such short time, it still is a clean example of computational analysis
  • Nice use of figures and tables to present the results
  • Good work in the modeling section finding the comparable set of faculty/OAA that did not sign the letter. I wonder if there's a way to automate collecting the directory or if it can be obtained in bulk. This way you wouldn't have to limit the analysis to the hand coded sample of departments
  • Nice use of a data pipeline to run the code. In the future consider if it makes sense to generate the graphs and models in the R Markdown document itself. Then you can include the code in the output. Even if you don't want to directly show the code, you could store it in collapsable chunks like @JordanAMartin did
  • Some of the code could be written more efficiently. For instance, why create both tenurestatus and division? You could have stored that in one data frame rather than two.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant