Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rishi's Peer Review #1

Open
rishigarora opened this issue Dec 11, 2016 · 0 comments
Open

Rishi's Peer Review #1

rishigarora opened this issue Dec 11, 2016 · 0 comments

Comments

@rishigarora
Copy link

rishigarora commented Dec 11, 2016


Topic Excellent Satisfactory Needs Work
Coding style X
Coding strategy X
Presentation: graphs X
Presentation: tables X
Achievement, creativity X
Ease of access X

Remarks:

  • The website isn't loading so I forked the repo to try and evaluate it. A lot of the code didn't run on its own, I had to install lots of packages. You shouldn't assume folks already have all of the packages installed. I can't get the rmd file to knit
  • I couldn't get the wordclouds to run but it's not obvious to me what's wrong
  • Some of the code could be automated further (e.g. no need to have 5+ mutate functions in a row)
  • Readme could've been more informative in describing all of the various files and datasets in the repo. Also names of files could be more descriptive
  • The ambition of the project is commendable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant