From 911ab26bfb90b16746e19d2270ea8e8649071eb6 Mon Sep 17 00:00:00 2001 From: Adam <41971533+jcadam14@users.noreply.github.com> Date: Wed, 17 Jan 2024 10:48:20 -0500 Subject: [PATCH] Added confirmation_id and contact_info to Submission and Filing DAO/DTO --- src/entities/models/dao.py | 5 +++-- src/entities/models/dto.py | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/entities/models/dao.py b/src/entities/models/dao.py index 61866294..40cb1e58 100644 --- a/src/entities/models/dao.py +++ b/src/entities/models/dao.py @@ -21,6 +21,7 @@ class SubmissionDAO(Base): validation_ruleset_version: Mapped[str] validation_json: Mapped[dict[str, Any]] = mapped_column(JSON, nullable=True) filing: Mapped[str] = mapped_column(ForeignKey("filing.id")) + confirmation_number: Mapped[str] def __str__(self): return f"Submission ID: {self.id}, Submitter: {self.submitter}, State: {self.state}, Ruleset: {self.validation_ruleset_version}, Filing: {self.filing}" @@ -42,8 +43,8 @@ class FilingDAO(Base): lei: Mapped[str] state: Mapped[FilingState] = mapped_column(SAEnum(FilingState)) filing_period: Mapped[int] = mapped_column(ForeignKey("filing_period.id")) - institution_snapshot_id = Mapped[str] # not sure what this is - + institution_snapshot_id: Mapped[str] + contact_info: Mapped[str] # Commenting out for now since we're just storing the results from the data-validator as JSON. # If we determine building the data structure for results as tables is needed, we can add these diff --git a/src/entities/models/dto.py b/src/entities/models/dto.py index 1ec961a6..ecb6aacb 100644 --- a/src/entities/models/dto.py +++ b/src/entities/models/dto.py @@ -13,6 +13,7 @@ class SubmissionDTO(BaseModel): validation_ruleset_version: str | None = None validation_json: Dict[str, Any] | None = None filing: int + confirmation_number: str | None = None class FilingDTO(BaseModel): @@ -23,6 +24,7 @@ class FilingDTO(BaseModel): state: FilingState filing_period: int institution_snapshot_id: str + contact_info: str class FilingPeriodDTO(BaseModel):