Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CSS cruft #1939

Closed
anselmbradford opened this issue Mar 28, 2024 · 6 comments
Closed

Clean up CSS cruft #1939

anselmbradford opened this issue Mar 28, 2024 · 6 comments

Comments

@anselmbradford
Copy link
Member

anselmbradford commented Mar 28, 2024

Describe the bug

Post BEM conversion (see #1919), here is some additional CSS that can be removed:

  • a-tagline--xlarge
  • content--2-1
  • content__wrapper--match-content - this class is being created because content__wrapper extends wrapper, which defines wrapper--match-content.
  • content__bleedbar

Some refactoring:

@anselmbradford
Copy link
Member Author

anselmbradford commented Apr 19, 2024

content__bleedbar removed in #1954
a-tagline--xlarge removed in #1960

@sonnakim
Copy link
Member

@anselmbradford will update this issue

@anselmbradford
Copy link
Member Author

content__wrapper--match-content removed in #1997
o-form--input-w-btn removed in #1979

@sonnakim
Copy link
Member

sonnakim commented Oct 1, 2024

@anselmbradford would you mind updating the status of this one?

@anselmbradford
Copy link
Member Author

o-table-wrapper--scrolling renamed in #2068

@anselmbradford
Copy link
Member Author

I'm going to close this. The last item, content--2-1, is only used in BAH/OAH Rate Explorer. We could remove it from the DS and re-create it in BAH, but there's a similar class, content--3-1, which has wider use and it seems better to keep those two together. If Rate Explorer removes content--2-1, we can remove it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants