From cd5f5f0d399e62b1c268e80e1185fd245d3ff20d Mon Sep 17 00:00:00 2001
From: Ans <git@anselmbradford.com>
Date: Wed, 3 Apr 2024 14:52:22 -0400
Subject: [PATCH 1/2] Featured cards tidying

---
 .../v1/includes/molecules/feature-card.html   | 76 +++++++++----------
 .../v1/includes/organisms/feature-cards.html  | 47 ++++++------
 2 files changed, 61 insertions(+), 62 deletions(-)

diff --git a/cfgov/v1/jinja2/v1/includes/molecules/feature-card.html b/cfgov/v1/jinja2/v1/includes/molecules/feature-card.html
index 82423f38326..53212863285 100644
--- a/cfgov/v1/jinja2/v1/includes/molecules/feature-card.html
+++ b/cfgov/v1/jinja2/v1/includes/molecules/feature-card.html
@@ -16,8 +16,6 @@
    value.category.url:           A string for the URL of the category page.
 
    value.category.text:          A string for the title of the category.
-                               
-   value.category.aria_label:    (Optional) An aria-label for the category page link.
 
    value.icon:                   A string corresponding to an SVG icon.
 
@@ -40,44 +38,46 @@
 
 <article class="m-card">
     <h2 class="m-card_heading">
-        <a class="" href="{{ value.category.url }}">
-<span class="m-card_icon">{{ svg_icon( value.icon ) }}</span>
-<span>{{ value.category.text }}</span>
-</a>
+        <a href="{{ value.category.url }}">
+            <span class="m-card_icon">{{ svg_icon( value.icon ) }}</span>
+            <span>{{ value.category.text }}</span>
+        </a>
     </h2>
-     
-<ul class="m-list">
-{%- for link in value.links %}
-<li class="m-list_item">
-{%- if link.text is not none and link.text.find('@') > -1 -%}
-    {%- if not value.emails is defined -%}
-        {%- do value.update({'emails':[{'url':link.text}]}) -%}
-    {%- endif -%}
-    {% include 'contact-email.html' with context %}
-{%- else -%}
-    {%- set link_text = link.text if link.text
-        else 'Learn More' -%}
-
-    {%- set link -%}
-        <a class="a_link a-link__partially-styled"
-            href="{{ link.url }}"
-            {%- if link.aria_label -%}
-                aria-label="{{ link.aria_label }}"
-            {%- endif %}>
-            <span class="a-link__partially-styled_plain">{{ link_text }} </span>
-            <span class="a-link__partially-styled_underlined">{{ _('Read answer') }}</span>
+
+    <ul class="m-list">
+        {%- for link in value.links %}
+        <li class="m-list_item">
+        {%- if link.text is not none and link.text.find('@') > -1 -%}
+            {%- if not value.emails is defined -%}
+                {%- do value.update({'emails':[{'url':link.text}]}) -%}
+            {%- endif -%}
+            {% include 'contact-email.html' with context %}
+        {%- else -%}
+            {%- set link_text = link.text if link.text else 'Learn More' -%}
+            {%- set link -%}
+                <a class="a_link a-link__partially-styled"
+                   href="{{ link.url }}"
+                   {%- if link.aria_label -%}
+                   aria-label="{{ link.aria_label }}"
+                   {%- endif %}>
+                    <span class="a-link__partially-styled_plain">
+                        {{ link_text }}
+                    </span>
+                    <span class="a-link__partially-styled_underlined">
+                        {{ _('Read answer') }}
+                    </span>
+                </a>
+            {%- endset -%}
+            {{ link | safe }}
+        {%- endif %}
+        </li>
+        {%- endfor %}
+    </ul>
+
+    <div class="m-card_footer">
+        <a href="{{ value.category.url }}">
+            {{ value.footer_label }}
         </a>
-    {%- endset -%}
-    {{ link | safe }}
-{%- endif %}
-</li>
-{%- endfor %}
-</ul>
-
-<div class="m-card_footer">
-    <a href="{{ value.category.url }}">
-        {{ value.footer_label }}
-    </a>
     </div>
 
 </article>
diff --git a/cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html b/cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html
index 979d80357f8..ee3d1e44637 100644
--- a/cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html
+++ b/cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html
@@ -23,27 +23,26 @@ <h2 class="u-show-on-mobile u-mt45">
         Browse questions by category
     </h2>
 
-<ul class="u-show-on-mobile category_list m-list m-list__links u-mb0">
-{% for card in value.feature_cards %}
-    <li class="m-list_item">
-        <a class="m-list_link a-link a-link__jump a-link__icon-after-text" href="{{ card.category.url }}">
-            <span class="a-link_text">{{ card.category.text }}</span>
-            {{ svg_icon( card.icon ) }}
-        </a>
-    </li>
-{% endfor %}
-</ul>
-
-<div class="u-hide-on-mobile question-categories u-mb30">
-<div class="o-card-group o-card-group__column-2">
-<div class="o-card-group_cards">
-
-{% for card in value.feature_cards %}
-    {{- feature_card(card) }}
-{% endfor %}
-
-</div>
-</div>
-</div>
-
-</section>
\ No newline at end of file
+    <ul class="u-show-on-mobile category_list m-list m-list__links u-mb0">
+    {% for card in value.feature_cards %}
+        <li class="m-list_item">
+            <a class="m-list_link a-link a-link__jump a-link__icon-after-text" href="{{ card.category.url }}">
+                <span class="a-link_text">{{ card.category.text }}</span>
+                {{ svg_icon( card.icon ) }}
+            </a>
+        </li>
+    {% endfor %}
+    </ul>
+
+    <div class="u-hide-on-mobile question-categories u-mb30">
+        <div class="o-card-group o-card-group__column-2">
+            <div class="o-card-group_cards">
+
+            {% for card in value.feature_cards %}
+                {{- feature_card(card) }}
+            {% endfor %}
+
+            </div>
+        </div>
+    </div>
+</section>

From 78fa2b21f1ea04e7d10fe31858005d2a3a325b64 Mon Sep 17 00:00:00 2001
From: Ans <git@anselmbradford.com>
Date: Wed, 3 Apr 2024 15:24:01 -0400
Subject: [PATCH 2/2] Remove unused `ask-categories` class

---
 cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html b/cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html
index ee3d1e44637..54aa0768bcb 100644
--- a/cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html
+++ b/cfgov/v1/jinja2/v1/includes/organisms/feature-cards.html
@@ -18,7 +18,7 @@
 {%- from 'v1/includes/blocks/heading.html' import heading without context %}
 {%- from 'v1/includes/molecules/feature-card.html' import feature_card with context %}
 
-<section class="ask-categories">
+<section>
     <h2 class="u-show-on-mobile u-mt45">
         Browse questions by category
     </h2>