Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stalls in the middle of model generation and will run forever #69

Open
mazeau opened this issue Mar 23, 2019 · 10 comments
Open

Stalls in the middle of model generation and will run forever #69

mazeau opened this issue Mar 23, 2019 · 10 comments

Comments

@mazeau
Copy link

mazeau commented Mar 23, 2019

Sometimes the model generation will stall after

Summary of Model Enlargement
---------------------------------
Added 1 new core species
    [CH]=C=C=C(C)C=C=C=C=C(28628)
Created 0 new edge species
Moved 1 reactions from edge to core
    C#CC#CC(23824) + C#CC#C[CH2](26090) <=> [CH]=C=C=C(C)C=C=C=C=C(28628)
Added 0 new core reactions
Created 0 new edge reactions

After model enlargement:
    The model core has 200 species and 2234 reactions
    The model edge has 43657 species and 108156 reactions

in the RMG.log. This specific RMG.log was last written at 9:41 AM (as well as the chemkin folders and the solver folder) and seems to just stop writing to anywhere and doing anything until it times out, then the error.log file is written (1:44 PM).

The next step should be to write Adding reaction library Surface/CPOX_Pt/Deutschmann2006 to output file..., but for some reason can't? Searching for the new species 28628 in the output.html yields nothing.

This only happens for some models with -1.5 to -3.5 carbon binding energies.

@mazeau
Copy link
Author

mazeau commented Oct 24, 2019

some profiles of models that were terminated before they could finish
dumping the ones that at first glance aren't duplicates here before I overwrite them
RMG.profile.dot.pdf
RMG.profile.dot.pdf
RMG.profile.dot.pdf
RMG.profile.dot.pdf
RMG.profile.dot.pdf
RMG.profile.dot.pdf
RMG.profile.dot.pdf
RMG.profile.dot.pdf

one that was able to finish:
RMG.profile.dot.pdf

@mliu49
Copy link

mliu49 commented Oct 24, 2019

It would be helpful to know the kinds of molecules being simulated and how far each of the jobs got for the different profiles.

That aside, I just looked at the last one, which had 87% time in find_degenerate_reactions and 45% time in ensure_species. I would definitely say that this is not normal, and my first guess is that there is a species with a ton of resonance structures - ensure_species is the first time that resonance structures are generated for new species, and find_degenerate_reactions does isomorphism which would be slow if there are species with tons of resonance structures.

The species added to core mentioned in the first comment [CH]=C=C=C(C)C=C=C=C=C only has 2 resonance structures though. Does the model also contain heteroatoms? It is possible that that species combined with a heteroatom with lone pairs could result in a ton of resonance structures.

@mazeau
Copy link
Author

mazeau commented Oct 24, 2019

No, there is only C and H in the system. This is oligomerization/dimerization of ethylene with n-heptane as a solvent. I also ran into this in some CPOX models

@rwest
Copy link
Collaborator

rwest commented Oct 24, 2019

The opening comment of this issue may not be relevant to these profiles - it is 7 months old, and I forget what we were even simulating then. Emilie, could you share the input file and perhaps the log for one of these? Might be informative to see what was added to the core just before the end

@rwest
Copy link
Collaborator

rwest commented Oct 24, 2019

Worth saying: this is with heterogeneous surfaces. Not sure our resonance stuff has been well tested there

@mazeau
Copy link
Author

mazeau commented Oct 24, 2019

input.py.txt
RMG.log

@rwest
Copy link
Collaborator

rwest commented Oct 24, 2019

Lol. Look at those edge species!

image
image
image

I know the point is to model oligemerization (and hence some polymerization, as an unwanted but important pathway) but perhaps we could put some constraints on the size of a molecule, and also the number of radicals it contains,

@mliu49
Copy link

mliu49 commented Oct 24, 2019

It's possible that this isn't due to a couple molecules with tons of resonance structures, but the accumulation of tons of molecules with many resonance structures. It's hard to say for sure though.

I think limiting the number of radicals would likely help.

@rwest
Copy link
Collaborator

rwest commented Oct 31, 2019

Just following up here, in case we refer to this thread again in future.

Analyzing the dictionary of species from the edge of one of Emily's models that ran for a long time with a huge majority of time spent generating and comparing resonance structures...

Number of resonance structures : Number of species of this type
1 : 457
2 : 82
3 : 546
4 : 47
5 : 7
6 : 352
7 : 1
8 : 9
9 : 270
10 : 2
12 : 52
15 : 2
16 : 1
18 : 204
24 : 5
27 : 79
36 : 50
54 : 25
81 : 15

Here are some of the ones with 54 resonance structures:
image
image
image

If you reduce it to only species with 2 or fewer radicals, you have fewer of the top end.

Number of resonance structures : Number of species of this type
1 : 457
2 : 82
3 : 481
4 : 40
5 : 6
6 : 256
7 : 1
8 : 4
9 : 82
12 : 11
16 : 1

so a constraint of this type should help speed up model generation.

@mliu49
Copy link

mliu49 commented Oct 31, 2019

I see, that makes a lot of sense. Each of these species has 3 localized regions with 3 resonance forms and 1 region with 2 resonance forms, giving 3x3x3x2=54 total resonance structures.

I wonder if there's a good way to cut down on these besides limiting the number of radicals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants